summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter H. Froehlich <[email protected]>2016-09-27 16:58:29 -0400
committerFrans Kaashoek <[email protected]>2017-01-30 19:31:24 -0500
commite916d668f7b184c41ee3d912ccda8cc7ca4aa765 (patch)
tree315e85ce1da63dd0452130484942a81efd4ae111
parent462930727fa9a9d61912264683d9f26e992412c6 (diff)
downloadxv6-labs-e916d668f7b184c41ee3d912ccda8cc7ca4aa765.tar.gz
xv6-labs-e916d668f7b184c41ee3d912ccda8cc7ca4aa765.tar.bz2
xv6-labs-e916d668f7b184c41ee3d912ccda8cc7ca4aa765.zip
Fix unsigned conversion bug.
Since readi() returns -1 for errors, checking with < against an unsigned value is inadvisable. Checking with != works as intended however.
-rw-r--r--exec.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/exec.c b/exec.c
index 6be6af1..4d7d97c 100644
--- a/exec.c
+++ b/exec.c
@@ -28,7 +28,7 @@ exec(char *path, char **argv)
pgdir = 0;
// Check ELF header
- if(readi(ip, (char*)&elf, 0, sizeof(elf)) < sizeof(elf))
+ if(readi(ip, (char*)&elf, 0, sizeof(elf)) != sizeof(elf))
goto bad;
if(elf.magic != ELF_MAGIC)
goto bad;