diff options
author | Austin Clements <[email protected]> | 2010-09-02 15:37:05 -0400 |
---|---|---|
committer | Austin Clements <[email protected]> | 2010-09-02 15:42:25 -0400 |
commit | f53e6110bed159c8541c6e0d2fc1b1ffac2d141a (patch) | |
tree | b71b99eb612d27fb054a07ff149668e579fb5fb2 | |
parent | b3cfd7fc372424d754f5478c93f6fbe756d9c80f (diff) | |
download | xv6-labs-f53e6110bed159c8541c6e0d2fc1b1ffac2d141a.tar.gz xv6-labs-f53e6110bed159c8541c6e0d2fc1b1ffac2d141a.tar.bz2 xv6-labs-f53e6110bed159c8541c6e0d2fc1b1ffac2d141a.zip |
Simplify inituvm and userinit by assuming initcode fits on a page
-rw-r--r-- | defs.h | 2 | ||||
-rw-r--r-- | proc.c | 7 | ||||
-rw-r--r-- | vm.c | 20 |
3 files changed, 10 insertions, 19 deletions
@@ -160,7 +160,7 @@ char* uva2ka(pde_t*, char*); int allocuvm(pde_t*, char*, uint); int deallocuvm(pde_t *pgdir, char *addr, uint sz); void freevm(pde_t*); -void inituvm(pde_t*, char*, char*, uint); +void inituvm(pde_t*, char*, uint); int loaduvm(pde_t*, char*, struct inode *ip, uint, uint); pde_t* copyuvm(pde_t*,uint); void switchuvm(struct proc*); @@ -120,11 +120,8 @@ userinit(void) initproc = p; if(!(p->pgdir = setupkvm())) panic("userinit: out of memory?"); - if(!allocuvm(p->pgdir, 0x0, (int)_binary_initcode_size)) - panic("userinit: out of memory?"); - inituvm(p->pgdir, 0x0, _binary_initcode_start, - (int)_binary_initcode_size); - p->sz = PGROUNDUP((int)_binary_initcode_size); + inituvm(p->pgdir, _binary_initcode_start, (int)_binary_initcode_size); + p->sz = PGSIZE; memset(p->tf, 0, sizeof(*p->tf)); p->tf->cs = (SEG_UCODE << 3) | DPL_USER; p->tf->ds = (SEG_UDATA << 3) | DPL_USER; @@ -267,20 +267,14 @@ loaduvm(pde_t *pgdir, char *addr, struct inode *ip, uint offset, uint sz) } void -inituvm(pde_t *pgdir, char *addr, char *init, uint sz) +inituvm(pde_t *pgdir, char *init, uint sz) { - uint i, pa, n, off; - pte_t *pte; - - for(i = 0; i < sz; i += PGSIZE){ - if(!(pte = walkpgdir(pgdir, (void *)(i+addr), 0))) - panic("inituvm: pte should exist\n"); - off = (i+(uint)addr) % PGSIZE; - pa = PTE_ADDR(*pte); - if(sz - i < PGSIZE) n = sz - i; - else n = PGSIZE; - memmove((char *)pa+off, init+i, n); - } + char *mem = kalloc(); + if (sz >= PGSIZE) + panic("inituvm: more than a page"); + memset(mem, 0, PGSIZE); + mappages(pgdir, 0, PGSIZE, PADDR(mem), PTE_W|PTE_U); + memmove(mem, init, sz); } // given a parent process's page table, create a copy |