summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorkaashoek <kaashoek>2006-09-07 00:00:33 +0000
committerkaashoek <kaashoek>2006-09-07 00:00:33 +0000
commitf9bc4452b5437570f1709430e9364cc3e323cf3a (patch)
tree6cec5651ee4316b451e7394daf37da005976314a
parentd6b20251f0094661b32b08973f536102d6e9dfeb (diff)
downloadxv6-labs-f9bc4452b5437570f1709430e9364cc3e323cf3a.tar.gz
xv6-labs-f9bc4452b5437570f1709430e9364cc3e323cf3a.tar.bz2
xv6-labs-f9bc4452b5437570f1709430e9364cc3e323cf3a.zip
nit in console interrupts
-rw-r--r--Notes5
-rw-r--r--console.c1
2 files changed, 3 insertions, 3 deletions
diff --git a/Notes b/Notes
index 8b47668..74c8aea 100644
--- a/Notes
+++ b/Notes
@@ -103,9 +103,10 @@ test: deadlock d/.. vs ../d, two processes.
test: dup() shared fd->off
test: does echo foo > x truncate x?
-sh: support pipes? leave it for the class?
+sh: ioredirection incorrect now we have pipes
+sh: chain of pipes won't work, also ugly that parent closes fdarray entries too
sh: dynamic memory allocation?
-sh: should sh support ; () & --- need malloc
+sh: should sh support ; () &
sh: stop stdin on ctrl-d (for cat > y)
really should have bdwrite() for file content
diff --git a/console.c b/console.c
index 8deca87..418aa84 100644
--- a/console.c
+++ b/console.c
@@ -178,7 +178,6 @@ console_write(int minor, char *buf, int n)
}
-// This is i8042reg.h + kbdreg.h from NetBSD.
#define KBSTATP 0x64 // kbd controller status port(I)
#define KBS_DIB 0x01 // kbd data in buffer
#define KBDATAP 0x60 // kbd data port(I)