summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Cross <[email protected]>2019-03-20 17:28:13 +0000
committerFrans Kaashoek <[email protected]>2019-08-19 19:25:43 -0400
commit82638c019ced44651d65c99aaa7c698676c217be (patch)
treefd3c7c1894a7fe4a220d2cc46112f9bfec6f984e
parent0581c37baf8950ae9602a1419498a800f9fade4f (diff)
downloadxv6-labs-82638c019ced44651d65c99aaa7c698676c217be.tar.gz
xv6-labs-82638c019ced44651d65c99aaa7c698676c217be.tar.bz2
xv6-labs-82638c019ced44651d65c99aaa7c698676c217be.zip
Avoid rereading the superblock in bfree
The superblock is read when the first process returns to userspace (via the call to `iinit` from the first invocation of `forkret`, when `first` is still set to 1) and cached in a global; it is treated as immutable from that point on. There is no reason to re-read it in bfree. Removing this call seems to have simply been missed in 8320d61b when this general area was last touched. Remove it now to avoid potential confusion. Signed-off-by: Dan Cross <[email protected]>
-rw-r--r--fs.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs.c b/fs.c
index feb59fe..f77275f 100644
--- a/fs.c
+++ b/fs.c
@@ -84,7 +84,6 @@ bfree(int dev, uint b)
struct buf *bp;
int bi, m;
- readsb(dev, &sb);
bp = bread(dev, BBLOCK(b, sb));
bi = b % BPB;
m = 1 << (bi % 8);