From 1a81e38b17144624415d252a521fd5a06079d681 Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Tue, 11 Jan 2011 13:01:13 -0500 Subject: make new code like old code Variable declarations at top of function, separate from initialization. Use == 0 instead of ! for checking pointers. Consistent spacing around {, *, casts. Declare 0-parameter functions as (void) not (). Integer valued functions return -1 on failure, 0 on success. --- defs.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'defs.h') diff --git a/defs.h b/defs.h index d08609d..43f35d2 100644 --- a/defs.h +++ b/defs.h @@ -62,7 +62,7 @@ void ioapicinit(void); // kalloc.c char* kalloc(void); void kfree(char*); -void kinit(); +void kinit(void); // kbd.c void kbdintr(void); @@ -117,8 +117,8 @@ void getcallerpcs(void*, uint*); int holding(struct spinlock*); void initlock(struct spinlock*, char*); void release(struct spinlock*); -void pushcli(); -void popcli(); +void pushcli(void); +void popcli(void); // string.c int memcmp(const void*, const void*, uint); @@ -164,7 +164,7 @@ void inituvm(pde_t*, char*, uint); int loaduvm(pde_t*, char*, struct inode *, uint, uint); pde_t* copyuvm(pde_t*,uint); void switchuvm(struct proc*); -void switchkvm(); +void switchkvm(void); int copyout(pde_t *pgdir, uint va, void *buf, uint len); // number of elements in fixed-size array -- cgit v1.2.3