From 4587b35847b116057e3ef1058da914b8837ff343 Mon Sep 17 00:00:00 2001 From: Robert Morris Date: Sun, 19 Sep 2010 07:18:42 -0400 Subject: exec questions --- exec.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'exec.c') diff --git a/exec.c b/exec.c index 222f64c..a6de18f 100644 --- a/exec.c +++ b/exec.c @@ -48,6 +48,9 @@ exec(char *path, char **argv) } iunlockput(ip); + // XXX rtm: what about the BSS? shouldn't there be some + // bzero()ing here? + // Allocate and initialize stack at sz sz = spbottom = PGROUNDUP(sz); if(!(sz = allocuvm(pgdir, sz, sz + PGSIZE))) @@ -62,6 +65,9 @@ exec(char *path, char **argv) sp = sz; argp = sz - arglen - 4*(argc+1); + // XXX rtm: does the following code work if the + // arguments &c do not fit in one page? + // Copy argv strings and pointers to stack. *(uint*)(mem+argp-spbottom + 4*argc) = 0; // argv[argc] for(i=argc-1; i>=0; i--){ -- cgit v1.2.3