From 0a4a4230a32696ef7f1f6272ca24520826195b7f Mon Sep 17 00:00:00 2001 From: Robert Morris Date: Mon, 8 Aug 2016 13:06:38 -0400 Subject: shell nits fix Regehr complaint --- sh.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'sh.c') diff --git a/sh.c b/sh.c index 16e325b..3ac6f5b 100644 --- a/sh.c +++ b/sh.c @@ -147,7 +147,7 @@ main(void) static char buf[100]; int fd; - // Assumes three file descriptors open. + // Ensure that three file descriptors are open. while((fd = open("console", O_RDWR)) >= 0){ if(fd >= 3){ close(fd); @@ -158,8 +158,7 @@ main(void) // Read and run input commands. while(getcmd(buf, sizeof(buf)) >= 0){ if(buf[0] == 'c' && buf[1] == 'd' && buf[2] == ' '){ - // Clumsy but will have to do for now. - // Chdir has no effect on the parent if run in the child. + // Chdir must be called by the parent, not the child. buf[strlen(buf)-1] = 0; // chop \n if(chdir(buf+3) < 0) printf(2, "cannot cd %s\n", buf+3); -- cgit v1.2.3